Genesys Cloud - Developer Community!

In OkHttpResponse#close method (Github link), you do nothing there. But in fact, the response object, which is an OkHttp's Reponse should be closed, as it implements the AutoClosable interface of Java.

We had this message regulary before :

We did not reproduced it on demand, but it was due to the fact that the response is not closed on the SDK side.
The very moment we used reflection (in our code) to forcefully close the response when the SDK's OkHttpResponse#closemethod is called, the alert was no more seen.

So could you update the SDK's code of this class to transform  @Override public void close() throws Exception { }into  @Override public void close() throws Exception { response.close(); } please?

In OkHttpResponse#close method (Github link), you do nothing there. But in fact, the response object, which is an OkHttp's Reponse should be closed, as it implements the AutoClosable interface of Java.

We had this message regulary before :

We did not reproduced it on demand, but it was due to the fact that the response is not closed on the SDK side.
The very moment we used reflection (in our code) to forcefully close the response when the SDK's OkHttpResponse#closemethod is called, the alert was no more seen.

So could you update the SDK's code of this class to transform  @Override public void close() throws Exception { }into  @Override public void close() throws Exception { response.close(); } please?

Hello,

I have some issues reproducing this.

Could you please try with this code as well if you don't mind, and see if it also makes the alert disappear?

@Override
public void close() throws Exception {
  if (response != null && response.body() != null) {
    response.close();
  }
}

Thank you.

Regards,

In OkHttpResponse#close method (Github link), you do nothing there. But in fact, the response object, which is an OkHttp's Reponse should be closed, as it implements the AutoClosable interface of Java.

We had this message regulary before :

We did not reproduced it on demand, but it was due to the fact that the response is not closed on the SDK side.
The very moment we used reflection (in our code) to forcefully close the response when the SDK's OkHttpResponse#closemethod is called, the alert was no more seen.

So could you update the SDK's code of this class to transform  @Override public void close() throws Exception { }into  @Override public void close() throws Exception { response.close(); } please?

Hello Jerome,

I beg you pardon, you are right the null checks on the response and its body seems to be a good idea.
In our case, as we don't make API calls without body I didn't take this in account, but I did effectively checked that the response does exist before trying to close it.

Sorry, I totally forgot to mention it in my first post.

Hello,

I have some issues reproducing this.

Could you please try with this code as well if you don't mind, and see if it also makes the alert disappear?

@Override
public void close() throws Exception {
  if (response != null && response.body() != null) {
    response.close();
  }
}

Thank you.

Regards,

In OkHttpResponse#close method (Github link), you do nothing there. But in fact, the response object, which is an OkHttp's Reponse should be closed, as it implements the AutoClosable interface of Java.

We had this message regulary before :

We did not reproduced it on demand, but it was due to the fact that the response is not closed on the SDK side.
The very moment we used reflection (in our code) to forcefully close the response when the SDK's OkHttpResponse#closemethod is called, the alert was no more seen.

So could you update the SDK's code of this class to transform  @Override public void close() throws Exception { }into  @Override public void close() throws Exception { response.close(); } please?